Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
bolekk
force-pushed
the
org_cache
branch
2 times, most recently
from
September 6, 2026 04:16
6dc7da5 to
4d79e91
Compare
bolekk
force-pushed
the
org_cache
branch
2 times, most recently
from
September 6, 2026 15:10
e3e706a to
bf47f10
Compare
bolekk
marked this pull request as ready for review
September 6, 2026 15:24
bolekk
requested review from
ibrajer,
jmank88,
patrickhuie19 and
pavel-raykov
and removed request for
skudasov
September 6, 2026 15:24
pavel-raykov
reviewed
Sep 7, 2026
| # RequestTimeout bounds each organization lookup against the linking service. | ||
| RequestTimeout = '2s' # Default | ||
| # CacheEnabled turns on durable Postgres-backed caching of owner->orgID mappings. | ||
| CacheEnabled = true # Default |
Collaborator
There was a problem hiding this comment.
nit: probably call it DurableCacheEnabled to underscore that the durable cache is enabled (the inmemory one is always on)
pavel-raykov
reviewed
Sep 7, 2026
| "chainlink": minor | ||
| --- | ||
|
|
||
| #added Durable caching of OrgResolver owner->orgID mappings (backed by Postgres, `CRE.Linking.CacheEnabled`, enabled by default). |
Collaborator
There was a problem hiding this comment.
nit: can you update PR description / link JIRA to clarify why durable caching is needed.
pavel-raykov
previously approved these changes
Sep 7, 2026
Cache owner->orgID mappings in Postgres (CRE-5348). CacheEnabled now defaults to true. Requires chainlink-common with the merged caching OrgResolver refactor (#2342).
|
pavel-raykov
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the caching OrgResolver implemented in smartcontractkit/chainlink-common#2342
Inject a DB-based cache. Enabled by default with a config flag to disable.